Config viper bug fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelrebel
reviewed
Aug 23, 2024
joelrebel
previously approved these changes
Aug 23, 2024
jakeschuurmans
force-pushed
the
ConfigViperBugFix
branch
from
d0a7a0d
to
b682910
Compare
joelrebel
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Viper has a limitation that doesnt allow it to use ENV variables as overrides unless the key was found in the yaml that is read in. This leads to mysterious values not being set. So I added a function to read through and set a default value for every struct item in config so you never have to worry about it.
Small fix for dummy config so it matches the Configuration struct.