Fix, refactor and unit test machine issues. #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently machine issues are not shown with text. :(
I introduced better interface for issue evaluation to enhance maintainability of the code.
This prepares it moving to another place as well because metalctl is maybe not the best place for defining what machine issues are. metal-api would be better fit for this but metalctl and metal-api do not have common API representations such that metalctl would not be able to use the code from metal-api.