Replace magic number 4 with NUM_STATES. Add comments. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 84.62% 84.62%
=======================================
Files 8 8
Lines 2036 2036
=======================================
Hits 1723 1723
Misses 313 313 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #108 will not alter performanceComparing Summary
|
messense
reviewed
Apr 15, 2024
messense
reviewed
Apr 15, 2024
messense
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the hmm code more understandable for folks (like me) who don't actually know viterbi well.
Also avoids leaking magic number from the implementation into the public API.