Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to mesos-role #770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vidhyaarvind
Copy link

Adding support to single role. Default is still * role

@vidhyaarvind
Copy link
Author

@brndnmtthws could you please review this?

@@ -73,7 +73,7 @@ class MesosJobFramework @Inject()(

def getReservedResources(offer: Offer): (Double, Double) = {
val resources = offer.getResourcesList.asScala
val reservedResources = resources.filter({ x => x.hasRole && x.getRole != "*" })
val reservedResources = resources.filter({ x => x.hasRole && x.getRole != config.mesosRole()})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the reverse logic. The original version of this method was correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can double check to see if this rejects * role offers, my cluster currently does not have any agents with * role

@@ -36,7 +36,7 @@ class MesosTaskBuilder @Inject()(val conf: SchedulerConfiguration) {
.setName(name)
.setType(Value.Type.SCALAR)
.setScalar(Value.Scalar.newBuilder.setValue(value))
.setRole("*")
.setRole(conf.mesosRole())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brndnmtthws Resource was taking * as the hardcoded value. Now the conf value set in --mesos-role is used. I have tested in mesos using multiple chronos frameworks and various roles. My cluster now does not have * roles. Also using Resource.newBuilder we can only setRole. Its's not possible to add multiple roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants