[Docs] Fix WSL1 hide/show button UX issue #2079
Conversation
Signed-off-by: Shulammite-Aso <asoamarachi@gmail.com>
probot-autolabeler
bot
added
area/docs
|
✔️ Deploy preview for meshery-docs ready! 🔨 Explore the source changes: 5ad917d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fda302ce272930008b2087b 😎 Browse the preview: https://deploy-preview-2079--meshery-docs.netlify.app |
|
Hi 🙋 @leecalcote Please review. |
|
Oh! very good. 👀 |
| @@ -83,7 +83,7 @@ wsl --set-default-version 2 | |||
| <b>Advertencia:</b> | |||
| Se recomienda actualizar a <a href="#wsl2">WSL2</a> ya que WSL1 no soporta la aplicación Docker Desktop para Windows. En su lugar, solo soporta la versión obsoleta, [Docker Toolbox](https://docs.docker.com/toolbox/toolbox_install_windows/). | |||
|
|
|||
| Si aun desea continuar, siga las instrucciones para <button onclick="HideToggleFunction()"><b>WSL1</b></button> | |||
| Si aun desea continuar, siga las instrucciones para <button class="WSL1-button" onclick="HideToggleFunction()"><b>WSL1</b></button> | |||
There was a problem hiding this comment.
Good work, @Shulammite-Aso. You accounted for the Spanish version, too. 😄
There was a problem hiding this comment.
Yeah @leecalcote 😆 These were the two places i saw the button in use.
|
Looks great. The button is much more obvious now. Good work! @Shulammite-Aso |
|
@chandrashritii is this button to be broadly used? If so, let’s consider a class name change. |
|
Yes @leecalcote |
Okay @chandrashritii , will toggle-button work? if not exactly, could you give an example? |
|
@Shulammite-Aso yes, sounds real good. This kind of functionality is useful on a number of other pages. |
Signed-off-by: Shulammite-Aso <asoamarachi@gmail.com>
|
@leecalcote @chandrashritii done. |
|
Yay! @Shulammite-Aso 🎈 |
Signed-off-by: Shulammite-Aso asoamarachi@gmail.com
Description
This PR fixes #2026
Notes for Reviewers
Signed commits