Adds 'Switch' as an Alias for 'Checkout` #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the regex to allow either 'checkout' or 'switch' 2. Changes to gitGraphParser.spec.js - Additional test coverage added for the changes made to the parser. 3. Changes to gitGraphParserV2.spec.js - Additional test coverafe added for the changes made to the parser. 4. Changes to gitgraph.md - Updated documentation to let users know that checkout/switch can be used interchangeably.
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5445 +/- ##
==========================================
- Coverage 5.74% 5.74% -0.01%
==========================================
Files 276 277 +1
Lines 41886 41897 +11
Branches 514 489 -25
==========================================
Hits 2407 2407
- Misses 39479 39490 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
FutzMonitor
changed the title
FutzMonitor
changed the title
sidharthv96
approved these changes
Apr 8, 2024
- Added additional rendering test functionality for recognizing 'switch' as an alias to 'checkout'.
I only added two rendering test because it seems redundant to have |
|
Thanks for taking the time for my issue @FutzMonitor , and with breathtaking speed too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Adds
switchas an alias forcheckout.Resolves #5422
📏 Design Decisions
Updated the regex that returns
CHECKOUTto also work forswitch. I added some test coverage to both parser specs.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch