Feature/support fa kit custom icons

[jakobskrym]

📑 Summary

Extends the current fontawesome support to also handle the case of custom icons being served through the fak prefix.

• Loosely related to Ability to use svg images instead of boxes in sequence and flowchart diagram for use e.g. AWS Icons #1723
• Originally discussed in Custom icons #15

📏 Design Decisions

Logic already existed for the basic fontawesome prefixes so mainly extended that and added a section to the flowchart documentation about it.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🔖 targeted develop branch

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	38beca1
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/660cff0cda7fa100095e7163
😎 Deploy Preview	https://deploy-preview-5430--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 5.74%. Comparing base (e852596) to head (38beca1).

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5430   +/-   ##
=======================================
  Coverage     5.74%   5.74%           
=======================================
  Files          277     276    -1     
  Lines        41898   41886   -12     
  Branches       489     514   +25     
=======================================
  Hits          2407    2407           
+ Misses       39491   39479   -12     

Flag	Coverage Δ
unit	5.74% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/mermaid/src/dagre-wrapper/createLabel.js	0.00% <0.00%> (ø)
...ges/mermaid/src/diagrams/flowchart/flowRenderer.js	0.00% <0.00%> (ø)
packages/mermaid/src/rendering-util/createText.ts	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[sidharthv96]

Changes looks good.

Can you also move the replace function into utils, so that we can avoid duplicating the logic 3 times?

[jakobskrym]

Changes looks good.

Can you also move the replace function into utils, so that we can avoid duplicating the logic 3 times?

Will do 👍

[jakobskrym]

Done - also added some test cases for the util function and then tried with the demo to make sure it works as intended 👍 (removed it though as it's a bit of an edge case and I didn't want it to be dependent on my fontawesome kit).

[sidharthv96]

Nice work @jakobskrym 🚀

[mermaid-bot]

@jakobskrym, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

[jakobskrym]

@sidharthv96 any idea when this will make it out to production? Saw that it wasn't included in the latest release 🧐

[jakobskrym]

Another ping regarding this @sidharthv96 - really want to start using it in our projects 🙏