Feature/4661 gantt customize days of weekend #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for mermaid-js failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5358 +/- ##
===========================================
+ Coverage 44.67% 44.79% +0.12%
===========================================
Files 25 25
Lines 5341 5353 +12
Branches 27 27
===========================================
+ Hits 2386 2398 +12
Misses 2954 2954
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…Feature/4661_gantt_customize_days_of_weekend
|
@Ronid1 if you could try converting the remaining JS files into TS (in different PRs), that would be very helpful. It'll also help catch many underlying issues as well. You can get started by removing |
…feature/4661_gantt_customize_days_of_weekend
|
@sidharthv96 updated according to your review. Not really sure about the error I'm getting in the ci, would appreciate help with it. |
Merged
via the queue into
mermaid-js:develop
with commit Mar 22, 2024
d6c1a59
15 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Added configuration for weekend start day. Weekend can either start on Friday or Saturday, with Saturday remaining the default.
Resolves #4661
📏 Design Decisions
Only added configurations for
fridayandsaturdaysince these are the days that weekends traditionally start on. In either case, the weekend is 2 days long. Maintained the lowercase standards from other components of Gantt.configuration can be added to the graph using this line:
weekend fridayor
weekend saturdayIf the
weekendkeyword is not used, the default will be saturday📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch