Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track outbound links in docs site. #5116

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

sidharthv96
Copy link
Member

📑 Summary

View conversion rates on promotion banner.

📏 Design Decisions

Unlike mermaid.live, there is no user provided links in mermaid.js.org.

So we can track the outbound link clicks without leaking any user data.

Unlike mermaid.live, there is no user provided links in mermaid.js.org.
So we can track the outbound link clicks without leaking any user data.
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 770fc41
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/657012864fba58000827a10c
😎 Deploy Preview https://deploy-preview-5116--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #5116 (770fc41) into master (78c44bf) will increase coverage by 3.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5116      +/-   ##
==========================================
+ Coverage   75.29%   78.31%   +3.01%     
==========================================
  Files         164      164              
  Lines       13820    13820              
  Branches      693      693              
==========================================
+ Hits        10406    10823     +417     
+ Misses       3243     2847     -396     
+ Partials      171      150      -21     
Flag Coverage Δ
e2e 83.90% <ø> (+3.75%) ⬆️
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@sidharthv96 sidharthv96 changed the title feat: Track outbound links feat: Track outbound links in docs site. Dec 6, 2023
Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aloisklink aloisklink merged commit c7b38b8 into master Dec 6, 2023
24 of 25 checks passed
@aloisklink aloisklink deleted the sidv/bannerClick branch December 6, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants