Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gantt): update styles #4930

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(gantt): update styles #4930

merged 1 commit into from
Nov 8, 2023

Conversation

Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Oct 9, 2023

📑 Summary

Brief description about the content of your PR.

  1. Removed duplicate css definition
  2. Fix the nesting css definition as current support coverage is too low.
  3. Apply titleText (which is used in other charts) to gantt chart
  4. A little reformat and comment removement

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 1fec55d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6523733fe10bc100089da88e
😎 Deploy Preview https://deploy-preview-4930--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4930 (1fec55d) into develop (12a4707) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4930   +/-   ##
========================================
  Coverage    79.97%   79.97%           
========================================
  Files          164      164           
  Lines        13623    13623           
  Branches       693      693           
========================================
  Hits         10895    10895           
  Misses        2579     2579           
  Partials       149      149           
Flag Coverage Δ
e2e 85.26% <ø> (ø)
unit 43.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/gantt/styles.js 100.00% <ø> (ø)

@sidharthv96 sidharthv96 added this pull request to the merge queue Nov 8, 2023
Merged via the queue into mermaid-js:develop with commit c2e26ba Nov 8, 2023
18 checks passed
@Mister-Hope Mister-Hope deleted the patch-2 branch November 9, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants