Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for theme-directives.html E2E test to render before taking a screenshot #4846

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Wait for theme-directives.html E2E test to render before taking a screenshot #4846

merged 2 commits into from
Sep 19, 2023

Commits on Sep 17, 2023

  1. test(e2e): remove unused code in theme-directives 

    We don't use any font-awesome icons, or custom fonts in this file.
    @aloisklink
    aloisklink committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    518e277 View commit details
    Browse the repository at this point in the history

  2. test(e2e): wait for theme-directives.html 

    The `theme-directives.html` test currently sometimes takes a screenshot
before all of the Mermaid diagrams have completed rendering.

We can use the `urlSnapshopTest()` helper function, which waits until
a `.rendered` property exists on the page.

Co-authored-by: Sidharth Vinod <sidharthv96@gmail.com>
    @aloisklink @sidharthv96
    aloisklink and sidharthv96 committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    17f5052 View commit details
    Browse the repository at this point in the history