Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1217 Better matching of words beginning with as as matching token #1229

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jan 29, 2020

📑 Summary

This allows removes incorrect matching if as in the state definition in stateDiagram.

Resolves #1217

📏 Design Decisions

Updated the grammar to be more strict when looking for the as keyword.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jan 29, 2020
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ashishjain0512 ashishjain0512 merged commit 39b873c into develop Jan 29, 2020
@ashishjain0512 ashishjain0512 deleted the bug/1217_fix_for_keyword_as_in_stateDiagram branch January 29, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateDiagram state as matches any word starting with as as an error
2 participants