Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1205 Adding parsing exception for then an inactive participant is inactivated #1207

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jan 15, 2020

📑 Summary

Making sure the participant id active when adding an inactivation signal.

Resolves #1205

📏 Design Decisions

When an inactivation signal is encounteted for an inactive node an error is thrown. One is manifactured to resemble the jison parsing errors.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • [-] 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jan 15, 2020
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@ashishjain0512 ashishjain0512 merged commit c9f95a1 into develop Jan 15, 2020
@ashishjain0512 ashishjain0512 deleted the bug/1205_activations_error branch January 15, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence Diagram Activations error
2 participants