Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1064 click event in class diagram #1170

Merged
merged 5 commits into from
Jan 5, 2020

Conversation

jgreywolf
Copy link
Contributor

@jgreywolf jgreywolf commented Jan 2, 2020

📑 Summary

Additional updates to handle click events in class diagrams
Added text sanitization for tooltips
Added handling for defining callback functions

Resolves #1064

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@jgreywolf
Copy link
Contributor Author

Man, picky little thing.

Updated documentation for Class Diagram with details for interactivity
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing that you moved sanitize function from diagram specific to utils. I think we have more work to do in that area. For instance svg rendering function that can be used by several diagrams.

@knsv knsv merged commit 37ae863 into mermaid-js:develop Jan 5, 2020
@jgreywolf jgreywolf deleted the 1064-ClickEventInClassDiagram branch January 6, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click event on a node in a classDiagram
2 participants