Bug/Clicking on a link only works directly on the node text

[GDFaber]

📑 Summary

Improved flowchart renderer to set links on the entire node so you can click a link anywhere on the node (before this modification it was only possible by clicking the node label).

Resolves #891

📏 Design Decisions

Used DOM manipulation inside the SVG node to wrap the shape as well as the label in an anchor object. Did not include additional tests to renderer, interaction or cypress integration because they already exist.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 🔖 targeted develop branch

[knsv]

Looks good!

[flying-sheep]

Great stuff! I already fixed that in some 0.x release, but it broke again. Kudos for fixing it again!

@dunning-kruger @jgreywolf since I can’t comment there because it’s locked – This works because of the way SVG differs from HTML:

1. pointer events (hover, click, …) register on the actual object’s shape, not some box around it.
2. <a> and <g> nodes also don’t create a box, but instead they affect all the shapes inside: <g fill=#f00><rect .../><circle .../></g> makes everything inside red, and <a href="..."><rect .../><circle .../></a> makes every shape inside link to the URL when clicked.