Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colour attribute of InternalTag to string #684

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sweep-from-cheng[bot]
Copy link
Contributor

Description

This PR changes the data type of the 'colour' attribute in the 'InternalTag' class from integer to string in the Python, JavaScript, and TypeScript SDKs. The 'colour' attribute is updated to correctly represent colours in the RRGGBB format as strings.

Summary of Changes

  • In python/internal_tags.py:
    • Modified the colour attribute in the InternalTag class to use the Property(str) data type.
  • In javascript/internal_tag.js:
    • Modified the colour attribute in the InternalTag class to use the string data type.
  • In typescript/src/internal_tag.ts:
    • Modified the colour attribute in the InternalTag class to use the string data type.

These changes ensure that the 'colour' attribute in the 'InternalTag' class correctly represents colours in the RRGGBB format as strings, aligning with the desired functionality.

Fixes #682.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

Sandbox Executions

  • Check python/internal_tags.py
Run python/internal_tags.py through the sandbox.
  • Check javascript/internal_tag.js
Run javascript/internal_tag.js through the sandbox.
  • Check typescript/src/internal_tag.ts
Run typescript/src/internal_tag.ts through the sandbox.

Copy link
Contributor Author

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sweep-from-cheng sweep-from-cheng bot added the sweep Sweep your software chores label Oct 31, 2023
Copy link
Contributor Author

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Copy link
Contributor Author

The command:
Run tsc
yielded the following error:
##[error]src/internal_tag.ts(8,4): error TS2304: Cannot find name 'Property'. ##[error]src/internal_tag.ts(11,4): error TS2304: Cannot find name 'Property'. ##[error]src/internal_tag.ts(14,4): error TS2304: Cannot find name 'Property'. ##[error]src/internal_tag.ts(17,4): error TS2304: Cannot find name 'Property'. ##[error]Process completed with exit code 2.
Here are the logs:


Copy link
Contributor Author

sweep-from-cheng bot commented Oct 31, 2023

🚀 Wrote Changes

Done.

@s3341458
Copy link
Collaborator

s3341458 commented Nov 1, 2023

Sweep: internal_tag.ts is already there in typescript/src/entities/ folder
so you should not create a new file should just update existing file

Copy link
Contributor Author

sweep-from-cheng bot commented Nov 1, 2023

🚀 Wrote Changes

Done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweep: this file not need to be created

Copy link
Contributor Author

@sweep-from-cheng sweep-from-cheng bot Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

I wasn't able to make changes. This could be due to an unclear request or a bug in my code.
As a reminder, comments on a file only modify that file. Comments on a PR (at the bottom of the "conversation" tab) can modify the entire PR. Please try again or contact us on Discord

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweep: just remove this file

Copy link
Contributor Author

@sweep-from-cheng sweep-from-cheng bot Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

I wasn't able to make changes. This could be due to an unclear request or a bug in my code.
As a reminder, comments on a file only modify that file. Comments on a PR (at the bottom of the "conversation" tab) can modify the entire PR. Please try again or contact us on Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Sweep your software chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: change colour internal tags from number to string
1 participant