meow--select: don't spam mark-ring #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, without this change, calling `meow-next-word` repeatedly on a selection created by `meow-mark-word` will repeatedly push the position at the beginning of the selection onto the mark-ring. This can quickly overflow the mark-ring, and it makes `pop-to-mark-command` a lot more annoying to use.
|
I think you inspired me that we should only keep one mark for each type of selection no matter how it gets extended. So I probably want to have this patch for all commands, and do it in a better way. |
|
Glad to hear it! The fact that all the Meow motions create selections means that the mark ring automatically becomes a tool for jumping back to previous edit positions. How would you feel about an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, without this change, calling
meow-next-wordrepeatedly on a selection created bymeow-mark-wordwill repeatedly push the position at the beginning of the selection onto the mark-ring. This can quickly overflow the mark-ring with identical positions, and it makespop-to-mark-commanda lot more annoying to use.