Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Overlapping elements for advanced queries #5

Closed
piyush-das opened this issue Jun 12, 2022 · 20 comments
Closed

[Bug] Overlapping elements for advanced queries #5

piyush-das opened this issue Jun 12, 2022 · 20 comments

Comments

@piyush-das
Copy link

Hi,
image
The Table view toggle button overlaps with the number of results of the query if title is h2
Thanks

@mendax1234
Copy link
Owner

Can you provide some detailed information about this bug , like showing your "code" of this specific part and l can have a check on it. Besides , l am very busy recently and l may not reply to you timely. Sorry for the inconvenience.

@piyush-das
Copy link
Author

Sure. Here's the code for generating it.

#+BEGIN_QUERY
{
:title  [ :h1 " Attempted Questions"]
:query [
       :find (pull ?p [*]) 
       :where (page-property ?p :source "Leetcode")]
}
#+END_QUERY

This would generate something like this.
image

It's perfectly all right, take your time. Loving your theme. I have reduced the header to an "h3" and that doesn't give me an overlap at all.
Great work !

@mendax1234
Copy link
Owner

Sure. Here's the code for generating it.

#+BEGIN_QUERY
{
:title  [ :h1 " Attempted Questions"]
:query [
       :find (pull ?p [*]) 
       :where (page-property ?p :source "Leetcode")]
}
#+END_QUERY

This would generate something like this. image

It's perfectly all right, take your time. Loving your theme. I have reduced the header to an "h3" and that doesn't give me an overlap at all. Great work !

Got it, l am working to fix it!

@mendax1234
Copy link
Owner

@piyush-das Let me know if this works well
The light mode:
image

The dark mode:
image

l will publish the latest version soon! If you have any further suggestions , feel free to put forward them here!

mendax1234 added a commit that referenced this issue Jun 19, 2022
@piyush-das
Copy link
Author

Love it !

@piyush-das
Copy link
Author

@mendax1234 I am getting the overlap again between the edit and properties button.
image

@mendax1234 mendax1234 reopened this Jun 21, 2022
@mendax1234
Copy link
Owner

Oops. Can you share your code again?

@piyush-das
Copy link
Author

Sure. Here's the code for generating it.

#+BEGIN_QUERY
{
:title  [ :h1 " Attempted Questions"]
:query [
       :find (pull ?p [*]) 
       :where (page-property ?p :source "Leetcode")]
}
#+END_QUERY

This would generate something like this. image
It's perfectly all right, take your time. Loving your theme. I have reduced the header to an "h3" and that doesn't give me an overlap at all. Great work !

Got it, l am working to fix it!

It's the same one, that I used previously. Maybe it would show up only when you actually do have results returning for the query.

@mendax1234
Copy link
Owner

It's the same one, that I used previously. Maybe it would show up only when you actually do have results returning for the query.

Since l am not familiar with query's syntax, so would you please provide your code so l can focus on the problem. Thanks.

@piyush-das
Copy link
Author

piyush-das commented Jun 22, 2022

@mendax1234 , Sorry for the misunderstanding..

#+BEGIN_QUERY
{
:title  [ :h2 " Attempted Questions"]
:query [
       :find (pull ?p [*]) 
       :where (page-property ?p :source "TestProperty")]
}
#+END_QUERY

However, in your case, since you have no pages with the page-property source set to "TestProperty" it would render correctly as follows :
Result :
image

So now in order to reproduce the bug, lets create a new page Testing Page with the source property set to TestProperty:

Testing Page
source:: TestProperty

And now if we look at the query result, it would look like this :
image

Thanks.

@mendax1234
Copy link
Owner

mendax1234 commented Jun 22, 2022

So now in order to reproduce the bug, lets create a new page Testing Page with the source property set to TestProperty:

Where do you put this code? Can you copy your whole code , thanks! @piyush-das

@piyush-das
Copy link
Author

piyush-das commented Jun 22, 2022

This is the whole code. Just create a new Page named Testing Page and put the following in it:

source:: TestProperty

image

And use this query code in any other page.

#+BEGIN_QUERY
{
:title  [ :h2 " Attempted Questions"]
:query [
       :find (pull ?p [*]) 
       :where (page-property ?p :source "TestProperty")]
}
#+END_QUERY

@mendax1234
Copy link
Owner

source:: TestProperty

Got it! Thanks for replying. Maybe l will fix it soon!

@mendax1234
Copy link
Owner

@piyush-das
Please see if it works now.
image
image

mendax1234 added a commit that referenced this issue Jun 22, 2022
@piyush-das
Copy link
Author

piyush-das commented Jun 22, 2022

Yup, the overlap is fixed. Can we have the enclosing side border prior to the fix. It might be a personal preference but I loved the aesthetics of it.

@mendax1234
Copy link
Owner

Yup, the overlap is fixed. Can we have the enclosing side border prior to the fix. It might be a personal preference but I loved the aesthetics of it.

@piyush-das
Does this fit you demand?
image

@piyush-das
Copy link
Author

I meant this.
image
I loved the curled border around the whole query. Although it's not a demand, only if you like the aesthetics as well. :)

@mendax1234
Copy link
Owner

I loved the curled border around the whole query. Although it's not a demand, only if you like the aesthetics as well. :)

Yes, l have added the curled border around the whole query, you can upgrade to the latest version to check if it works for you. The latest version is 1.2.2

@piyush-das
Copy link
Author

Although I preferred the previous borders more with the top border not completed. But this looks great as well. Thanks again for the great theme :)

@mendax1234
Copy link
Owner

If you have no problems, l will close this issue. Thanks for finding this bug about query table!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants