Modest cleanups for DSi_NAND #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- melonDS ignores it anyway
- Move bitwise operations on the title ID into helper methods - Use TitleMetadata objects instead of pointers to raw data
- Replace some constants with sizeof - Use an NDSHeader object instead of a raw array of bytes
- It will be reused in the next commit
- The bytes of the title ID/category were being swapped in most places, but not all
RayyanAnsari
requested changes
Jul 4, 2023
RSDuck
reviewed
Jul 7, 2023
kvnp
pushed a commit
to kvnp/melonDS
that referenced
this pull request
Dec 25, 2023
* Add a definition for TMD files * Wrap TitleMetadata in a namespace * Add a comment * Remove TitleMetadataCertificate - melonDS ignores it anyway * Refactor the use of title metadata - Move bitwise operations on the title ID into helper methods - Use TitleMetadata objects instead of pointers to raw data * Slight cleanup in DSi_NAND - Replace some constants with sizeof - Use an NDSHeader object instead of a raw array of bytes * Add a DSi_NAND::ImportFile overload that loads a file from memory * Split most of ImportTitle into InitTitleFileStructure - It will be reused in the next commit * Add ability to import title from memory * Fix another potential issue * Fix broken DSiWare installation - The bytes of the title ID/category were being swapped in most places, but not all * Add some logging calls * Declare array sizes in DSi_TMD in decimal, not hex * Add a space after the #endif - To adhere to the style guide * Assert the size of TitleMetadataContent * Change the type of SignatureName * Don't mark the TMD structs as packed * Remove extraneous comments * Cut down some newlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My latest chapter in the melonDS DS saga has led me to DSiWare support. Since melonDS doesn't support direct-booting DSiWare, I took an alternative approach; temporarily installing DSiWare and save data for the duration of a session, then exporting it back to the host at the end.
This PR introduces some odds and ends to make that simpler, including:
structdefinition for title metadata (minus the certificates)