Add protobuf support #264
Open
Add protobuf support #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few tests are working, before I add more, let me know your thoughts. Would you be open to merging this PR with more test coverage? |
|
Great! Protobuf support is on the wish list and very welcome. |
|
I was considering that as well. Since any object can be serialized into
either protobuf or avro, it seemed to make sense that the serialization is
done based on the ID of the schema in glue, not based on construction.
…On Mon, Jun 26, 2023 at 8:47 AM Felix ***@***.***> wrote:
Great! Protobuf support is on the wish list and very welcome.
I'm just thinking whether it's better to specify the type explicitly
during construction or implicitly during usage, depending on the type of
schema being used.
—
Reply to this email directly, view it on GitHub
<#264 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6BNNYSLXS6VQXTYAGPMD3DXNGOG3ANCNFSM6AAAAAAZTO4U6Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Makes sense. And when someone starts with a new schema he would have to specify the type anyhow. |
|
The unit tests in the branch currently don't work. Would you be able to provide a working version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.