Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type casting necessary due to insufficient types on ngrx #2

Closed
meeroslav opened this issue Jan 2, 2020 · 0 comments · Fixed by ngrx/platform#2299
Closed

type casting necessary due to insufficient types on ngrx #2

meeroslav opened this issue Jan 2, 2020 · 0 comments · Fixed by ngrx/platform#2299
Labels
enhancement New feature or request

Comments

@meeroslav
Copy link
Owner

Scope: ngrx helpers

ActionCreator extends the inner Creator type by adding TypedAction, however actual return type should be typed Creator - the function that returns original response hydrated with type.

This forces us to cast ActionCreator calls to Actions (and Observable)
@meeroslav meeroslav added the enhancement New feature or request label Jan 2, 2020
@meeroslav meeroslav mentioned this issue Jan 2, 2020
Merged
3 tasks
alex-okrushko pushed a commit to ngrx/platform that referenced this issue Jan 6, 2020
@meeroslav @alex-okrushko
fix(store): replace Creator with ActionCreator on createAction (#2299)
fe6bfa7 
* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck
incredibles007 pushed a commit to incredibles007/angular-platform-ngrx that referenced this issue Nov 22, 2021
@meeroslav @alex-okrushko
fix(store): replace Creator with ActionCreator on createAction (#2299)
b44d42e 
* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck
Morita0711 added a commit to Morita0711/e-commerce-angular that referenced this issue Jul 3, 2022
@Morita0711
fix(store): replace Creator with ActionCreator on createAction (#2299)
bc96e5b 
* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck
HoneyRole added a commit to HoneyRole/angular-ngrx that referenced this issue Nov 21, 2022
@HoneyRole
fix(store): replace Creator with ActionCreator on createAction (#2299)
6b2b59f 
* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck
bodyduardU pushed a commit to bodyduardU/platform that referenced this issue Dec 5, 2022
@meeroslav @alex-okrushko
fix(store): replace Creator with ActionCreator on createAction (#2299)
f5ba106 
* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck
incredibles007 pushed a commit to incredibles007/angular-platform-ngrx that referenced this issue Dec 14, 2023
@meeroslav @alex-okrushko
fix(store): replace Creator with ActionCreator on createAction (#2299)
7d08b64 
* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(store): replace Creator with ActionCreator on createAction meeroslav/platform
1 participant
@meeroslav