chore: Satisfy linter

meedstrom · Aug 24, 2024 · 9ae89a7 · 9ae89a7
1 parent 2561856
commit 9ae89a7
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 38 deletions.
diff --git a/org-node-backlink.el b/org-node-backlink.el
@@ -70,12 +70,15 @@
     (remove-hook 'before-save-hook
                  #'org-node-backlink--fix-flagged-parts-of-buffer t)))
 
+(defun org-node-backlink--enable ()
+  "Enable `org-node-backlink-mode' if buffer is Org-mode."
+  (when (derived-mode-p 'org-mode)
+    (org-node-backlink-mode)))
+
 ;;;###autoload
 (define-globalized-minor-mode org-node-backlink-global-mode
   org-node-backlink-mode
-  (lambda ()
-    (when (derived-mode-p 'org-mode)
-      (org-node-backlink-mode)))
+  org-node-backlink--enable
   :group 'org-node)
 
 

diff --git a/org-node.el b/org-node.el
@@ -2383,48 +2383,52 @@ Also add a corresponding entry to `org-node-series-dispatch'."
                       'incompatible)
           (list (seq-uniq (cons key old))))))
 
+;; These suffixes just exist due to a linter complaint, could
+;; have been lambdas
+
+(transient-define-suffix org-node--series-goto-previous* (args)
+  (interactive (list (transient-args 'org-node-series-dispatch)))
+  (if args
+      (org-node--series-goto-previous (car args))
+    (message "Choose series before navigating")))
+
+(transient-define-suffix org-node--series-goto-next* (args)
+  (interactive (list (transient-args 'org-node-series-dispatch)))
+  (if args
+      (org-node--series-goto-next (car args))
+    (message "Choose series before navigating")))
+
+(transient-define-suffix org-node--series-jump* (args)
+  (interactive (list (transient-args 'org-node-series-dispatch)))
+  (if args
+      (org-node--series-jump (car args))
+    (message "Choose series before navigating")))
+
+(transient-define-suffix org-node--series-capture (args)
+  (interactive (list (transient-args 'org-node-series-dispatch)))
+  (if args
+      (progn (setq org-node-current-series-key (car args))
+             (unwind-protect
+                 (let* ((series (cdr (assoc (car args) org-node--series)))
+                        (capture-keys (plist-get series :capture)))
+                   (if capture-keys
+                       (org-capture nil capture-keys)
+                     (message "No capture template for series %s"
+                              (plist-get series :name))))
+               (setq org-node-current-series-key nil)))
+    (message "Choose series before navigating")))
+
 ;;;###autoload (autoload 'org-node-series-dispatch "org-node" nil t)
 (transient-define-prefix org-node-series-dispatch ()
   :incompatible '(("d"))
   ["Series"
    ("|" "Invisible" "Placeholder" :if-nil t)
    ("d" "Dailies" "d")]
   ["Navigation"
-   ("p" "Previous in series"
-    (lambda (args)
-      (interactive (list (transient-args 'org-node-series-dispatch)))
-      (if args
-          (org-node--series-goto-previous (car args))
-        (message "Choose series before navigating")))
-    :transient t)
-   ("n" "Next in series"
-    (lambda (args)
-      (interactive (list (transient-args 'org-node-series-dispatch)))
-      (if args
-          (org-node--series-goto-next (car args))
-        (message "Choose series before navigating")))
-    :transient t)
-   ("j" "Jump (or create)"
-    (lambda (args)
-      (interactive (list (transient-args 'org-node-series-dispatch)))
-      (if args
-          (org-node--series-jump (car args))
-        (message "Choose series before navigating"))))
-   ("c" "Capture into"
-    (lambda (args)
-      (interactive (list (transient-args 'org-node-series-dispatch)))
-      (if args
-          (progn
-            (setq org-node-current-series-key (car args))
-            (unwind-protect
-                (let* ((series (cdr (assoc (car args) org-node--series)))
-                       (capture-keys (plist-get series :capture)))
-                  (if capture-keys
-                      (org-capture nil capture-keys)
-                    (message "No capture template for series %s"
-                             (plist-get series :name))))
-              (setq org-node-current-series-key nil)))
-        (message "Choose series before navigating"))))])
+   ("p" "Previous in series" org-node--series-goto-previous* :transient t)
+   ("n" "Next in series" org-node--series-goto-next* :transient t)
+   ("j" "Jump (or create)" org-node--series-jump*)
+   ("c" "Capture into" org-node--series-capture)])
 
 (defcustom org-node-series-that-marks-calendar nil
   "Key for the series that should mark days in the calendar.