Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious initial slash in empty relative path when calling .path() accessor #82

Closed
wants to merge 2 commits into from
Closed

Spurious initial slash in empty relative path when calling .path() accessor #82

wants to merge 2 commits into from

Commits on Apr 23, 2013

  1. Add tests demonstrating incorrect empty relative path serialization b… 

    …y uri.path() and uri.pathname().

Clearly the relative path from"/a/b/c/" to "/a/b/c/" is the empty relative path "", and not "/".

Equivalently, URI("").path() should return the empty string "", but in fact returns "/".

The empty relative path is serialized correctly by .toString(), but incorrectly by .path() and .pathname().
    @djcsdy
    djcsdy committed Apr 23, 2013
    Configuration menu
    Copy the full SHA
    8d0c31c View commit details
    Browse the repository at this point in the history

  2. Fix incorrect serialization of empty relative paths. 

    If the URI includes an authority component, then the path is always absolute. Otherwise, the path may be relative and we should not coerce an empty relative path to the empty absolute path.

We check for the presence of a hostname as a proxy for checking for an authority component, because in our implementation the presence of a hostname determines the presence of an authority component.

There was previously a check to see if the URI was a URN, but that is now redundant since a URN cannot include an authority component.
    @djcsdy
    djcsdy committed Apr 23, 2013
    Configuration menu
    Copy the full SHA
    8049654 View commit details
    Browse the repository at this point in the history