Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to get/set fragment prefix (#!, #?, #, etc) #55

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions src/URI.fragmentQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,26 +38,39 @@
var p = URI.prototype;
// old fragment handler we need to wrap
var f = p.fragment;
// NOTE: google want's #! (hashbang), others might want #? others might want plain #
// choose the prefix you want to use here
var prefix = '?';
// query-encoded fragments aren't standardized, and different codebases use
// different conventions (Google uses #!, Facebook a bare #, others #?).
// You can set the prefix for all URI objects with this variable, or modify
// it on an instance-by-instance basis using uri.fragmentPrefix("!")
URI.defaultPrefix = '?';

p.fragmentPrefix = function(newPrefix) {
if (newPrefix === undefined) {
if (this.prefix === undefined) {
return URI.defaultPrefix;
} else {
return this.prefix;
}
}
this.prefix = newPrefix;
return this;
}
// add fragment(true) and fragment({key: value}) signatures
p.fragment = function(v, build) {
if (v === true) {
return URI.parseQuery((this._parts.fragment || "").substring(prefix.length));
return URI.parseQuery((this._parts.fragment || "").substring(this.fragmentPrefix().length));
} else if (v !== undefined && typeof v !== "string") {
this._parts.fragment = prefix + URI.buildQuery(v);
this._parts.fragment = this.fragmentPrefix() + URI.buildQuery(v);
this.build(!build);
return this;
} else {
return f.call(this, v, build);
}
};
p.addFragment = function(name, value, build) {
var data = URI.parseQuery((this._parts.fragment || "").substring(prefix.length));
var data = URI.parseQuery((this._parts.fragment || "").substring(this.fragmentPrefix().length));
URI.addQuery(data, name, value);
this._parts.fragment = prefix + URI.buildQuery(data);
this._parts.fragment = this.fragmentPrefix() + URI.buildQuery(data);
if (typeof name !== "string") {
build = value;
}
Expand All @@ -66,9 +79,9 @@ p.addFragment = function(name, value, build) {
return this;
};
p.removeFragment = function(name, value, build) {
var data = URI.parseQuery((this._parts.fragment || "").substring(prefix.length));
var data = URI.parseQuery((this._parts.fragment || "").substring(this.fragmentPrefix().length));
URI.removeQuery(data, name, value);
this._parts.fragment = prefix + URI.buildQuery(data);
this._parts.fragment = this.fragmentPrefix() + URI.buildQuery(data);
if (typeof name !== "string") {
build = value;
}
Expand All @@ -81,4 +94,4 @@ p.removeHash = p.removeFragment;

// extending existing object rather than defining something new
return {};
}));
}));
8 changes: 7 additions & 1 deletion test/test_fragmentQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ test("storing query-data in fragment", function() {
u.removeFragment("name");
deepEqual(u.fragment(true), {}, "removing value name");
equal(u.toString(), "http://example.org/#?", "removing value name serialized");

u = URI("http://example.org/#foo=bar");
deepEqual(u.fragmentPrefix("").fragment(true), {foo: "bar"}, "empty fragment prefix");

u = URI("http://example.org/#!foo=bar");
deepEqual(u.fragmentPrefix("!").fragment(true), {foo: "bar"}, "alternative fragment prefix");
});

})();
})();