Fix Issue #264: Handle a few dot segment normalization corner cases better #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few normalization steps that URI parsers may perform, one is dot segment normalization and another is percent encoding normalization. The spec isn't clear on what order you should apply them, but in practice browsers seem to normalize percent encoding, then remove dot segments. That means that `/foo/%2E%2E/bar` == `/bar` Also, `/foo/..bar` should not have the dot segment removed.
rodneyrehm
added a commit
that referenced
this pull request
Dec 2, 2015
…lization fix(normalizePath): handle dot segment normalization edge cases - closes #264
rodneyrehm
added a commit
that referenced
this pull request
Dec 2, 2015
|
Thank you! (I had to cherry-pick your commit to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #264
There are a few normalization steps that URI parsers may perform,
one is dot segment normalization and another is percent encoding
normalization.
The spec isn't clear on what order you should apply them, but in
practice browsers seem to normalize percent encoding, then remove
dot segments.
That means that
/foo/%2E%2E/bar==/barAlso,
/foo/..barshould not have the dot segment removed.