Added string cast for non-string value being compared when removing query parameter. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yep, thank you!
it's certainly not your fault that github doesn't properly distinguish stable and master branches… This happens to many people (including me) across many projects all the time… |
rodneyrehm
added a commit
that referenced
this pull request
Sep 26, 2015
fix(removeQuery): adding cast-to-string for values being removed from query string.
Siltaar
added a commit
to Siltaar/URI.js
that referenced
this pull request
Oct 13, 2015
rodneyrehm
added a commit
that referenced
this pull request
Oct 13, 2015
|
released in v1.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better?
Sorry, I'm a fucking git n00b here. Usually works with TFS in my company.