Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more supporting methods for URN paths. #201

Merged
merged 6 commits into from
Mar 31, 2015

Commits on Mar 25, 2015

  1. Added more supporting methods for URN paths.

    Use case: I work on some software that needs to accept URNs that may be
    improperly formatted and encode them properly. This patch introduces a new
    method, `recodeURNPath`, that will break the URN's path into segments and
    make sure that each part of it is encoded properly.
    
    Risks: URI.js treats "URN" as a catch-all category for everything that doesn't
    look like an HTTP URL. Many of these schemes may or may not follow the URN
    syntactical rules.
    Matthew Lefavor committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    4be8afa View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2015

  1. Added finally clause to iso8859 and unicode methods.

    My local changes created a bug that caused an exception to be thrown during the `normalize` call of
    these methods, which then caused later tests to fail because the wrong decoding/encoding function
    was being used.
    Matthew Lefavor committed Mar 27, 2015
    Configuration menu
    Copy the full SHA
    8d68ead View commit details
    Browse the repository at this point in the history
  2. Responded to PR comments.

    Matthew Lefavor committed Mar 27, 2015
    Configuration menu
    Copy the full SHA
    1840662 View commit details
    Browse the repository at this point in the history
  3. Updated documentation to better reflect the distinction between URLs …

    …and URNs.
    Matthew Lefavor committed Mar 27, 2015
    Configuration menu
    Copy the full SHA
    46b270e View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2015

  1. Responded to PR review comments (round 2).

    1. Used more meaningful tags in the documentation.
    2. method names with "URN" in them have been camel-cased to use "Urn" instead.
    3. A list of resources and a changelog has been added to the README.
    Matthew Lefavor committed Mar 30, 2015
    Configuration menu
    Copy the full SHA
    8b057a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2015

  1. Cleaned up README file.

    Matthew Lefavor committed Mar 31, 2015
    Configuration menu
    Copy the full SHA
    158011d View commit details
    Browse the repository at this point in the history