-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strictEncodeURIComponent fails in FF 3.6 #91
Comments
Firefox 3.6, seriously? we're at 21. twentyone! |
Sure, we don't like it either, but in one of our products we embed that browser (or xulrunner actually). And it's not that easy to upgrade. |
let me get this straight, your fix is replacing .replace(/[!'()*]/g, escape) with .replace(/[!'()*]/g, function(v){return escape(v); }) and that's it? |
yep, that's it. It seems like FF 3.6 has some limitations in accessing native functions, I suppose this issue: jashkenas/backbone#2417 falls into the same category. |
well, that's easy enough. I'll include that in the next version |
great, thanks! |
I've fixed this in master - it will be included in the next release. thank you for your help! |
Calling strictEncodeURIComponent with some specific values cause an error in FF 3.6.
I hotfixed this by replacing the escape-function that is passed into replace with:
The text was updated successfully, but these errors were encountered: