strictEncodeURIComponent fails in FF 3.6

[NetForce1]

Calling strictEncodeURIComponent with some specific values cause an error in FF 3.6.

strictEncodeURIComponent('abcdefg()') // -> Error: invalid string escape mask 8

I hotfixed this by replacing the escape-function that is passed into replace with:

function(val) {return escape(val);}

[rodneyrehm]

Firefox 3.6, seriously? we're at 21. twentyone!

[NetForce1]

Sure, we don't like it either, but in one of our products we embed that browser (or xulrunner actually). And it's not that easy to upgrade.

[rodneyrehm]

let me get this straight, your fix is replacing

.replace(/[!'()*]/g, escape)

with

.replace(/[!'()*]/g, function(v){return escape(v); })

and that's it?

[NetForce1]

yep, that's it. It seems like FF 3.6 has some limitations in accessing native functions, I suppose this issue: jashkenas/backbone#2417 falls into the same category.

[rodneyrehm]

well, that's easy enough. I'll include that in the next version

[NetForce1]

great, thanks!

[rodneyrehm]

I've fixed this in master - it will be included in the next release. thank you for your help!