Spurious initial slash in empty relative path when calling .path() accessor #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y uri.path() and uri.pathname().
Clearly the relative path from"/a/b/c/" to "/a/b/c/" is the empty relative path "", and not "/".
Equivalently, URI("").path() should return the empty string "", but in fact returns "/".
The empty relative path is serialized correctly by .toString(), but incorrectly by .path() and .pathname().
If the URI includes an authority component, then the path is always absolute. Otherwise, the path may be relative and we should not coerce an empty relative path to the empty absolute path. We check for the presence of a hostname as a proxy for checking for an authority component, because in our implementation the presence of a hostname determines the presence of an authority component. There was previously a check to see if the URI was a URN, but that is now redundant since a URN cannot include an authority component.
|
What's the status on this? are there still things missing? I've started merging the open stuff into master |
|
I believe this is safe to merge. |
rodneyrehm
added a commit
that referenced
this pull request
Aug 3, 2013
|
I've merged this into master - it will be included in the next release. thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit logs for rationale behind the changes made.