-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possible to get/set fragment prefix (#!, #?, #, etc) #55
Conversation
In this case I'd add a static property |
Pardon my weak JS, but won't that set the default for all future URI() instances? I thought it more elegant to make it configurable on a per URI basis, no? |
Well, yes. All I said was move the Regarding the testing, just open the /test directory in your browser. the testing framework is QUnit. fiddle with it! |
Right. I believe I made it as you suggested and added a couple of tests. I hope you'll choose to merge this; and thanks for |
I added some comments to your latest commit. :) |
Have you given up on this? |
Not at all, but then life happened, you know. |
…gmentQuery extensions - Issue #55
This has been fixed and released in v1.8.2. |
Thanks for wrapping this up and sorry I dropped the ball on ya... :) |
oh please… you were the reason this came up and I actually looked for good solution. both fragment abuse extensions were initially only meant to inspire custom implementations, not be used literally. I think that has changed now, thanks to you! :) |
The patch is pretty straightforward.
I apologize for not adding tests; perhaps I can recommend adding a "how to contribute" bit in the docs that will mention exactly how to run them.