Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to get/set fragment prefix (#!, #?, #, etc) #55

Closed
wants to merge 1 commit into from
Closed

make it possible to get/set fragment prefix (#!, #?, #, etc) #55

wants to merge 1 commit into from

Conversation

yaniv-aknin
Copy link

The patch is pretty straightforward.
I apologize for not adding tests; perhaps I can recommend adding a "how to contribute" bit in the docs that will mention exactly how to run them.

@rodneyrehm
Copy link
Member

In this case I'd add a static property URI.default_fragment_prefix = '!' and import that on URI instantiation.

@yaniv-aknin
Copy link
Author

Pardon my weak JS, but won't that set the default for all future URI() instances? I thought it more elegant to make it configurable on a per URI basis, no?

@rodneyrehm
Copy link
Member

Well, yes. All I said was move the defaultPrefix variable onto URI so it is actually configurable. That allows you to configure once and use everywhere, while still being able to use some different prefix for specific URI instances...

Regarding the testing, just open the /test directory in your browser. the testing framework is QUnit. fiddle with it!

@yaniv-aknin
Copy link
Author

Right. I believe I made it as you suggested and added a couple of tests. I hope you'll choose to merge this; and thanks for URI.js!

@rodneyrehm
Copy link
Member

I added some comments to your latest commit. :)

@rodneyrehm
Copy link
Member

Have you given up on this?

@yaniv-aknin
Copy link
Author

Not at all, but then life happened, you know.
I'll try to get to it this week, there's really not that much to do.

rodneyrehm added a commit that referenced this pull request Dec 27, 2012
@rodneyrehm
Copy link
Member

This has been fixed and released in v1.8.2.
(Thank you for your effort!)

@rodneyrehm rodneyrehm closed this Dec 27, 2012
@yaniv-aknin
Copy link
Author

Thanks for wrapping this up and sorry I dropped the ball on ya... :)

@rodneyrehm
Copy link
Member

oh please… you were the reason this came up and I actually looked for good solution. both fragment abuse extensions were initially only meant to inspire custom implementations, not be used literally. I think that has changed now, thanks to you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants