Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong protocol identification for relative URL with colons #49

Closed
Ragnarokkr opened this issue Oct 20, 2012 · 2 comments
Closed

Wrong protocol identification for relative URL with colons #49

Ragnarokkr opened this issue Oct 20, 2012 · 2 comments
Labels
Bug

Comments

@Ragnarokkr
Copy link

I think to have found a minor issue, in URI parsing.

You can replicate this issue using the Wikipedia links. For example, parsing a local URL on Wikipedia:

<a href="/wiki/Help:IPA">....</a>

the URI.parse() method returns for protocol

/wiki/Help

and for path

IPA

and this is clearly wrong.
@rodneyrehm
Copy link
Member

good catch! I'll look into it

rodneyrehm added a commit that referenced this issue Oct 21, 2012
@rodneyrehm
Fixing issue #49 - /wiki/Help:IPA would yield wrong protocol: "/wik…
7ed74b6 
…i/Help"
@rodneyrehm
Copy link
Member

This issue has been adressed and is fixed in v1.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rodneyrehm @Ragnarokkr