-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URI constructor does not take an object as value for query property #366
Comments
Hey there! Providing an object was originally meant to be used internally for convenient cloning. But since it's public API I guess we may want to make this a little more consistent. You could extend With this change you'd also be able to pass I guess this change should not only apply to Would you like to submit a PR for this change? |
I'm glad to actually find an opportunity to contribute 😄 Will look into this in the next few days, In case of any doubt I'll comment here, if you don't mind. edit: if you want you can assign it to me ;) |
I was a bit lost, I don't know if what I made makes total sense, let me know if I need to fix something. |
closed by #367 |
released as v1.19.1 |
Hello everyone,
Please let me know if this is this has been decided to be like this or not, but when building an URL, query property only takes a string as value, instead of search() or query() that take both string and objects.
Heres an example code (online repl here):
The text was updated successfully, but these errors were encountered: