-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append to path and work correctly with or without trailing slash in url #34
Comments
I was thinking about adding a function |
Could it simply append it after the filename? I'm not sure what would be the expected behavior, but I'm basically looking for a way to append and I don't have to deal with filenames in this instance. Is there a common use case for appending something to the path but have it be inserted before a filename anyhow? I think an append method that goes after everything but before the query string and hash would satisfy my requirement, but might need to call it something other than pathSegment if it appends after a filename? |
Of course it could, this would be the simplest approach.
no idea. that's why I'm looking for some input.
well, pathSegment() or even segment() is just fine, as long as appending is a tertiary operation. |
I've added .segment(). It will be included in the next release. |
can work or not depending if the first part ends with a /. I'd rather not hack the adding of a slash in JavaScript or use any sort of rewriting.
Would it make sense to add an appendPath method or something like that?
The text was updated successfully, but these errors were encountered: