Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withinString modifies captured url - . gets lost #325

Closed
Bonuspunkt opened this issue Jan 29, 2017 · 2 comments
Closed

withinString modifies captured url - . gets lost #325

Bonuspunkt opened this issue Jan 29, 2017 · 2 comments
Labels

Comments

@Bonuspunkt
Copy link

code

const URI = require("urijs");
const text = "https://msdn.microsoft.com/en-us/library/windows/desktop/ms644989(v=vs.85).aspx";
URI.withinString(text, function(url) {
	console.log(text);
	console.log(url);
});

output

https://msdn.microsoft.com/en-us/library/windows/desktop/ms644989(v=vs.85).aspx
https://msdn.microsoft.com/en-us/library/windows/desktop/ms644989(v=vs.85)aspx
@rodneyrehm
Copy link
Member

thank you! I've landed a fix in master and will relase a new version tomorrow :)

@rodneyrehm
Copy link
Member

fix released in v1.18.5

astorije added a commit to thelounge/thelounge that referenced this issue Apr 20, 2017
astorije added a commit to thelounge/thelounge that referenced this issue Apr 20, 2017
astorije added a commit to thelounge/thelounge that referenced this issue Apr 21, 2017
xPaw pushed a commit to thelounge/thelounge that referenced this issue Apr 21, 2017
xPaw pushed a commit to thelounge/thelounge that referenced this issue Apr 21, 2017
eliemichel pushed a commit to eliemichel/lounge that referenced this issue Aug 31, 2017
matburnham pushed a commit to matburnham/lounge that referenced this issue Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants