Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseQuery TypeError when first group reference is null #220

Closed
rur opened this issue Jun 22, 2015 · 3 comments
Closed

parseQuery TypeError when first group reference is null #220

rur opened this issue Jun 22, 2015 · 3 comments

Comments

@rur
Copy link

rur commented Jun 22, 2015

URI.parseQuery('?test&test=123')
=> TypeError: Cannot read property 'push' of null

URI.parseQuery('?test=123&test')
=> {"test" : ["123",null]}

Also, should parse query pass through invalid URI components?

URI.parseQuery('?%=123')
=> {"%" : "123"}
@rodneyrehm
Copy link
Member

URI.parseQuery('?test&test=123')

interesting, a bug indeed.

Also, should parse query pass through invalid URI components?

yes, I think that's fine.

@rodneyrehm
Copy link
Member

fixed in master

@rur
Copy link
Author

rur commented Jun 23, 2015

awesome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants