URI(undefined) now throws type error

[joladev]

Note that this differs from URI() which still works as a shortcut for
URI(location).

Since there is no reason to explicitly call URI with undefined, it is
safe to assume that this happens because of user error. URI now
correctly throws a type error with a message explaining that undefined
is not a valid argument.

[rodneyrehm]

released v1.15.0, thank you for your support!

[KyleNeedham]

This breaks the ability to do URI() since it creates an instance of itself passing url, base which are both undefined.

See #205

[joladev]

@KyleNeedham You should probably have tested that before commenting. And read the description of the pull request. The URI() short hand exists as a test in the code base and the tests all pass.

URI(undefined) no longer works, while URI() still works fine.

[KyleNeedham]

@eakron Please read my issue. URI() does not work currently. You should probably have tested that.

[rodneyrehm]

@KyleNeedham is correct, URI() breaks, while new URI() works. tests only exist for the latter.

Tracked in #205

[joladev]

@rodneyrehm There are no tests for URI()? I see, that's unfortunate. I just assumed that after our discussion... My bad, do you want me to make a new pull request? We should add a test and fix the bug.

[rodneyrehm]

I've already added tests and fixed the issue, pushing just now…

[joladev]

@rodneyrehm Sweet, nice catch.