Merge pull request #196 from eakron/master

fixing `URI(undefined)` to throw TypeError
medialize · Mar 11, 2015 · b9b5635 · b9b5635
2 parents 962f222 + 35dd050
commit b9b5635
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/URI.js b/src/URI.js
@@ -40,6 +40,10 @@
     }
 
     if (url === undefined) {
+      if (arguments.length) {
+        throw new TypeError('undefined is not a valid argument for URI');
+      }
+
       if (typeof location !== 'undefined') {
         url = location.href + '';
       } else {

diff --git a/test/test.js b/test/test.js
@@ -85,6 +85,11 @@
       new URI(new Date());
     }, TypeError, 'Failing unknown input');
   });
+  test('new URI(undefined)', function() {
+    raises(function() {
+      new URI(undefined);
+    }, TypeError, 'Failing undefined input');
+  });
   test('new URI()', function() {
     var u = new URI();
     ok(u instanceof URI, 'instanceof URI');
@@ -1589,4 +1594,4 @@
     equal(URI.encodeReserved('ä:/?#[]@!$&\'()*+,;='), '%C3%A4:/?#[]@!$&\'()*+,;=');
   });
 
-})();
+})();