Protocol regex wrong?

[hackerwins]

There is a problem with the regular expression to determine the protocol.

URI.protocol_expression = /^[a-z][a-z0-9-+-]*$/i;

https://github.com/medialize/URI.js/blob/gh-pages/src/URI.js#L172

How about changing -+- to -+\. ?

http://stackoverflow.com/questions/3641722/valid-characters-for-uri-schemes

[rodneyrehm]

Not sure how that slipped by the tests. Good call. Do you want to send a PR?

[hackerwins]

@rodneyrehm Thanks to reply. Yeap. 👍

[ooxi]

Shouln't -+\. be -+. since it is already in a character class?

P.S.: Not sure about the following but I head that - should be the last character in a character class since it has a special meaning for character ranges like a-z. So I would suggest using .+- instead of -+-

[rodneyrehm]

It can, but it's not mandatory. I've made a habit of escaping things in character classes as well. and yes, if - is not escaped, it must come last.

[rodneyrehm]

The issue is resolved in v1.12.0