-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol regex wrong? #132
Comments
Not sure how that slipped by the tests. Good call. Do you want to send a PR? |
@rodneyrehm Thanks to reply. Yeap. 👍 |
Shouln't P.S.: Not sure about the following but I head that |
It can, but it's not mandatory. I've made a habit of escaping things in character classes as well. and yes, if |
The issue is resolved in v1.12.0 |
There is a problem with the regular expression to determine the protocol.
https://github.com/medialize/URI.js/blob/gh-pages/src/URI.js#L172
How about changing
-+-
to-+\.
?http://stackoverflow.com/questions/3641722/valid-characters-for-uri-schemes
The text was updated successfully, but these errors were encountered: