Get rid of String#substr

[mathiasbynens]

You may want to consider using String#substring or String#slice instead of the non-standard String#substr.

[rodneyrehm]

I've never met a browser not understanding String.substr() properly. I've been using this method for 5+ years without any problems what so ever?!

[mathiasbynens]

There may not be problems with it in current browsers, but if there’s a standard, fully specced method (and there are several options here) why not use that one?

Edit: Just to be clear: this was just a friendly heads up, I don’t mean to start a flamewar here.

[rodneyrehm]

No no no flamewar going on here! I'm just surprised by your intel.
Go ahead and replace those .substr() by whatever you seem fit. I'll be happy to merge…
(heading out to a meeting now ☹)

[rodneyrehm]

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/String/substr says substr() has been around since Javascript 1.0, although no ECMA specification. I wonder if this really is an issue :/

[mathiasbynens]

I wonder if this really is an issue :/

It’s not — it’s just good practice to use standardized methods where possible.

[rodneyrehm]

I don't disagree. I find it interesting, though, that both standardized methods slice() and substring() take an index as the end-point, rather then number of characters to read (like substr() in any other language I know does…). weird.

[rodneyrehm]

Fixed in v1.1.0