fixing IPv6 normalization (bad variable name) - closes #145

medialize · Apr 15, 2014 · e6238d3 · e6238d3
1 parent a89a70d
commit e6238d3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -228,6 +228,10 @@ URI.js is published under the [MIT license](http://www.opensource.org/licenses/m
 
 ## Changelog ##
 
+### master ###
+
+* fixing IPv6 normalization (bad variable name) - ([Issue #145](https://github.com/medialize/URI.js/issues/145))
+
 ### 1.13.0 (April 15th 2014) ###
 
 * fixing [`URI.parseHost()`](http://medialize.github.io/URI.js/docs.html#static-parseHost) and [`URI.buildHost()`](http://medialize.github.io/URI.js/docs.html#static-buildHost) to properly parse and build the IPv6 examples given in [RFC2732 Format for Literal IPv6 Addresses in URL's](http://tools.ietf.org/html/rfc2732#section-2) - ([Issue #144](https://github.com/medialize/URI.js/issues/144))

diff --git a/src/IPv6.js b/src/IPv6.js
@@ -151,7 +151,7 @@ function best(address) {
     // assemble remaining segments
     var result = '';
     if (segments[0] === '')  {
-        beststr = ":";
+        result = ":";
     }
 
     for (i = 0; i < length; i++) {

diff --git a/test/test.js b/test/test.js
@@ -936,6 +936,12 @@ test("normalizeHost", function() {
         equal(u+"", "http://[fe80::204:61ff:fe9d:f156]/foobar.html", "best IPv6 representation");
     }
 
+    if (window.IPv6) {
+        u = new URI("http://[::1]/foobar.html");
+        u.normalizeHostname();
+        equal(u+"", "http://[::1]/foobar.html", "best IPv6 representation");
+    }
+
     u = new URI("http://wWw.eXamplE.Org/foobar.html");
     u.normalizeHostname();
     equal(u+"", "http://www.example.org/foobar.html", "lower case hostname");