fixing issue #39 - segment() won't append properly if path ended with…

… "/"

README.md

@@ -184,6 +184,10 @@ URI.js is published under the [MIT license](http://www.opensource.org/licenses/m
 
 ## Changelog ##
 
+### next release ###
+
+* fixing [`.segment()`](http://medialize.github.com/URI.js/docs.html#accessors-segment)'s append operation ([Issue #39](https://github.com/medialize/URI.js/issues/39)
+
 ### 1.7.0 (August 11th 2012) ###
 
 * fixing URI() constructor passing of `base` ([Issue #33](https://github.com/medialize/URI.js/issues/33) [LarryBattle](https://github.com/LarryBattle))

package.json

@@ -22,6 +22,10 @@
         "url",
         "uri mutation",
         "url mutation",
+        "uri manipulation",
+        "url manipulation",
+        "uri template",
+        "url template",
         "unified resource locator",
         "unified resource identifier",
         "query string",

src/URI.js

@@ -1141,7 +1141,13 @@ p.segment = function(segment, v, build) {
         if (isArray(v)) {
             segments = v;
         } else if (v || (typeof v === "string" && v.length)) {
-            segments.push(v);
+            if (segments[segments.length -1] === "") {
+                // empty trailing elements have to be overwritten
+                // to prefent results such as /foo//bar
+                segments[segments.length -1] = v;
+            } else {
+                segments.push(v);
+            }
         }
     } else {
         if (v || (typeof v === "string" && v.length)) {

test/test.js

@@ -486,6 +486,12 @@ test("segment", function() {
     u.segment(1, 'mars');
     equal(u.path(), "foo:mars:baz", "segment set 1 URN");
     equal(u.toString(), "someurn:foo:mars:baz", "segment set 1 URN");
+
+    u = new URI('/foo/');
+    equal(u.segment().join('||'), "foo||", "segment get array trailing empty");
+
+    u.segment('test');
+    equal(u.path(), "/foo/test", "segment append trailing empty");
 });
 
 module("mutating query strings");