Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/59 LitElement example #704

Merged
merged 5 commits into from
Feb 26, 2023
Merged

Feature/59 LitElement example #704

merged 5 commits into from
Feb 26, 2023

Conversation

kusigit
Copy link
Contributor

@kusigit kusigit commented Feb 24, 2023

Typescript example with LitElement.

@kusigit kusigit changed the title LitElement example Feature 59: LitElement example Feb 24, 2023
@kusigit kusigit changed the title Feature 59: LitElement example Feature/59 LitElement example Feb 24, 2023
@mebjas
Copy link
Owner

mebjas commented Feb 24, 2023

Thanks for the example.

Please fix the codacy warnings and also update the readme.

@mebjas
Copy link
Owner

mebjas commented Feb 25, 2023

Looks good to me.

Please add one readme as well in this format: https://github.com/mebjas/html5-qrcode/blob/master/examples/vuejs/README.md

Please add yourself as author :)

Also, please add a reference here as well - https://github.com/mebjas/html5-qrcode#framework-support with link to the example.

@mebjas
Copy link
Owner

mebjas commented Feb 26, 2023

Thanks, merging!

@mebjas mebjas merged commit 5d10865 into mebjas:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mebjas mebjas mebjas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kusigit @mebjas