Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Content): [Web API ] update autonomous custom elements example #28480

Closed

Conversation

kemilbeltre
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

Fixes #28450

@kemilbeltre kemilbeltre requested a review from a team as a code owner August 9, 2023 21:24
@kemilbeltre kemilbeltre requested review from wbamberg and removed request for a team August 9, 2023 21:24
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Preview URLs

(comment last updated: 2023-08-10 09:24:55)

@sideshowbarker
Copy link
Collaborator

@kostasx Can you please review https://github.com/mdn/content/pull/28480/files and confirm whether it resolves issue #28450 to your satisfaction?

@kostasx
Copy link
Contributor

kostasx commented Aug 10, 2023

@sideshowbarker The addition of connectedCallback(){ certainly makes things more clear, but the problem is that the source code found on line 129 points to a file that contains the code within a constructor method instead which is a bit confusing.

@kemilbeltre
Copy link
Contributor Author

@sideshowbarker The addition of connectedCallback(){ certainly makes things more clear, but the problem is that the source code found on line 129 points to a file that contains the code within a constructor method instead which is a bit confusing.

It has also been requested to be updated.

@sideshowbarker
Copy link
Collaborator

After looking at mdn/web-components-examples#57 it seems like the code fix there is actually preferable, and the same change should be made to the content of the article

@kemilbeltre kemilbeltre deleted the fix/28450-using-custom-elements branch September 15, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading code description in the Custom Elements API documentation
3 participants