Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex reference #22210

Merged
merged 29 commits into from
May 5, 2023
Merged

Regex reference #22210

merged 29 commits into from
May 5, 2023

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Nov 10, 2022

@github-actions github-actions bot added the Content:JS JavaScript docs label Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Preview URLs (28 pages)
Flaws (5)

Note! 23 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Named_capturing_group
Title: Named capturing group: (?<name>...)
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.regular_expressions.named_capturing_group

URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Unicode_character_class_escape
Title: Unicode character class escape: \p{...}, \P{...}
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.regular_expressions.unicode_character_class_escape

URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Non-capturing_group
Title: Non-capturing group: (?:...)
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.regular_expressions.non-capturing_group

URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Literal_character
Title: Literal character: a, b
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.regular_expressions.literal_character

URL: /en-US/docs/Mozilla/Firefox/Releases/78
Title: Firefox 78 for developers
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/ParentNode/replaceChildren redirects to /en-US/docs/Web/API/Element/replaceChildren
External URLs (17)

URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions
Title: Regular expressions


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Word_boundary_assertion
Title: Word boundary assertion: \b, \B


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_class_escape
Title: Character class escape: \d, \D, \w, \W, \s, \S


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Named_capturing_group
Title: Named capturing group: (?<name>...)


URL: /en-US/docs/Web/JavaScript/Reference/Regular_expressions/Unicode_character_class_escape
Title: Unicode character class escape: \p{...}, \P{...}


URL: /en-US/docs/Web/JavaScript/Guide/Regular_expressions/Groups_and_backreferences
Title: Groups and backreferences


URL: /en-US/docs/Web/JavaScript/Guide/Regular_expressions/Assertions
Title: Assertions


URL: /en-US/docs/Mozilla/Firefox/Releases/78
Title: Firefox 78 for developers

(comment last updated: 2023-05-04 08:17:37)

@Rumyra
Copy link
Collaborator

Rumyra commented Nov 18, 2022

I for one really like the way this is going @Josh-Cena, folks seem quite positive about this content :)

I'll await a little more feedback from others, but I might open a tracking bug for the work moving forward (the roadmap is still a few weeks away which is a shame because this is the perfect thing for it)

@Josh-Cena Josh-Cena force-pushed the regex-reference branch 11 times, most recently from 876f1af to 8a8692e Compare November 19, 2022 21:47
@Josh-Cena
Copy link
Member Author

Josh-Cena commented Nov 19, 2022

Update: I have completed the scaffolds for all pages, but I'm missing a lot of examples, and I also plan to rearrange documentation about regexes in other places. Now is a good time to comment on the description sections, because I feel like I've stuffed in a lot of obscure details.

@Josh-Cena

This comment was marked as resolved.

@bsmth
Copy link
Member

bsmth commented Feb 23, 2023

BCD for the patterns has been merged in mdn/browser-compat-data#18966

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Josh-Cena - thanks for the wonderful improvements here, I'm happy to merge when you are!

One last check about flaws, but I think we're good 👍🏻

title: "Named capturing group: (?<name>...)"
slug: Web/JavaScript/Reference/Regular_expressions/Named_capturing_group
page-type: javascript-language-feature
browser-compat: javascript.regular_expressions.named_capturing_group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows a flaw which I presume is the "no spec found" warning:

https://pr22210.content.dev.mdn.mozit.cloud/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Named_capturing_group#specifications

Are we waiting on a BCD release with the latest data from there?

Copy link
Member Author

@Josh-Cena Josh-Cena May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the flaw is not about the spec data, as spec data is missing on every page, while the flaw is only raised for certain pages. The flaw may be because Yari does not have the latest BCD? As for the missing spec link, I honestly don't know—I'm as puzzled as you are. https://pr22210.content.dev.mdn.mozit.cloud/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Literal_character does have BCD table, which means mdn/browser-compat-data#19050 is already live, and the APIs ought to have spec links.

Copy link
Member

@bsmth bsmth May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the flaw is only raised for certain pages

That's the strange part - let's merge and keep an eye on this if it's resolved on nightly build, this might be only affecting the PR companion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants