Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mdn_urls: remove 404s, replace redirects, add new pages #23481

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Update mdn_urls: remove 404s, replace redirects, add new pages #23481

merged 5 commits into from
Jun 26, 2024

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jun 21, 2024 •
edited
Loading

This PR is the initial result of automatically updating mdn_urls in #23431.

@github-actions github-actions bot added data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG data:webdriver 🏎️ Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML data:wasm 🦾 Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly labels Jun 21, 2024
@Elchi3 Elchi3 mentioned this pull request Jun 21, 2024
Merged
@queengooborg queengooborg linked an issue Jun 21, 2024 that may be closed by this pull request
CSSStyleDeclaration's @@iterator link goes to a "Page not found" #23455
Closed
@Elchi3 Elchi3 requested a review from queengooborg June 22, 2024 11:21
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jun 22, 2024
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jun 22, 2024
Josh-Cena
Josh-Cena reviewed Jun 23, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script doesn't seem able to deal with capitalization differences. They should probably be fixed too

javascript/operators/conditional.json Show resolved Hide resolved
javascript/operators/import.json Show resolved Hide resolved
javascript/operators/property_accessors.json Show resolved Hide resolved
@Josh-Cena
Copy link
Member

FWIW this seems slightly inconvenient in the context of fixing MDN gaps, since every new doc now also requires a BCD update, but I think it's generally an improvement, and it'll probably take us a long while to fix all MDN gaps...

@Elchi3
Copy link
Member Author

Elchi3 commented Jun 24, 2024

Thanks @Josh-Cena and @rebloor!

The script doesn't seem able to deal with capitalization differences. They should probably be fixed too

Fixed!

queengooborg
queengooborg approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick spot check shows favorable results, so LGTM!

@queengooborg queengooborg merged commit 1d41e2a into mdn:main Jun 26, 2024
6 checks passed
@Elchi3 Elchi3 deleted the fix-mdn-urls branch June 26, 2024 08:23
@Elchi3 Elchi3 mentioned this pull request Jun 26, 2024
Closed
@skyclouds2001 skyclouds2001 mentioned this pull request Jul 1, 2024
Open
@saschanaz saschanaz mentioned this pull request Jul 3, 2024
Merged
@rubiesonthesky rubiesonthesky mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor rebloor left review comments

@Josh-Cena Josh-Cena Josh-Cena left review comments

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG data:wasm 🦾 Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly data:webdriver 🏎️ Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSSStyleDeclaration's @@iterator link goes to a "Page not found"
4 participants
@Elchi3 @Josh-Cena @queengooborg @rebloor