Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entry for input-security CSS property #12822

Closed
wants to merge 1 commit into from
Closed

Add entry for input-security CSS property #12822

wants to merge 1 commit into from

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow lukewarlow commented Oct 12, 2021 •
edited
Loading

Summary

Added an entry for the input-security CSS property.

Test results and supporting details

https://webkit.org/blog/11975/release-notes-for-safari-technology-preview-133/#:~:text=Added%20support%20for%20input-security - Safari TP supposedly supports this property but I and someone else haven't been able to get it working so have left as false for now. As of TP 134 this is now working so I've added it.

WebKit bug (implemented): https://webkit.org/b/184510

Firefox bug (in progress): https://bugzil.la/1735384

Chromium bug: https://crbug.com/1253732

Related issues

Fixes #12664

Related to mdn/content#9422 and mdn/content#10438

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 12, 2021
@lukewarlow lukewarlow marked this pull request as ready for review October 12, 2021 18:07
@lukewarlow lukewarlow mentioned this pull request Oct 12, 2021
Closed
Elchi3
Elchi3 requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should remove the -webkit-text-security file (and add it to input-security as and old alias).
https://github.com/mdn/browser-compat-data/blob/main/css/properties/-webkit-text-security.json

See also mdn/content#10438

@lukewarlow
Copy link
Contributor Author

It's not actually an alias of that property, as can be seen by its WebKit implementation.

@Elchi3 Elchi3 mentioned this pull request Nov 22, 2021
Closed
@Elchi3
Copy link
Member

Elchi3 commented Nov 22, 2021

I asked in mdn/content#10438 if we want one feature page here or if we should keep them separate.

@GPHemsley GPHemsley mentioned this pull request Jan 3, 2022
Open
@Elchi3
Copy link
Member

Elchi3 commented Jan 18, 2022

Removing my review request. Need info as requested in mdn/content#10438 (comment)

@Elchi3 Elchi3 removed their request for review January 18, 2022 10:02
@queengooborg
Copy link
Collaborator

Marking as "not ready" since this seems to be blocked on info needed for the content PR.

@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jan 29, 2022
@lukewarlow
Copy link
Contributor Author

Looks like Safari has put this behind a flag for now WebKit/WebKit@bed3cc8

@lukewarlow
Copy link
Contributor Author

And sounds like the CSSWG might drop the property from the spec entirely. w3c/csswg-drafts#6788

@lukewarlow
Copy link
Contributor Author

Given the above two points, and the lack of movement on the blocking discussion for this PR, I'm gonna go ahead and close it for now.

@lukewarlow lukewarlow closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 requested changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

input-security - Missing data
3 participants
@lukewarlow @Elchi3 @queengooborg