Re-add theme as Solarized Dark - Patched #63
Conversation
|
And for posterity's sake, here are some screenshots that illustrate the problem: the first is an issue in Vim using the patched theme that isn't present in the non-patched, and the second is a bug when the usage is flipped.
|
|
Fantastic, thank you! I'll take a look at it in depth tonight when I get home. Thanks Jake! |
Re-add theme as Solarized Dark - Patched
|
Hmmm, why provide a patched version and not fix the original one? Just wondering... |
|
That was precisely my point, and the point made by altercation; neither solution perfectly "fixes" the issue. The "fix" would be to rewrite ANSI escape codes to handle colors in a sane way instead of forcing people into a 16-color palette. If you look at the screenshots above, you can see that using the patched version makes Vim look bad, and using the non-patched version makes other programs look bad. Consider reading this thread for more information. |
|
Alright, thanks for the clarification and the info :). |
See this [issue] for reference. [issue]: mbadolato/iTerm2-Color-Schemes#63
I'm open to the name of this theme, but I chose "Solarized Dark - Patched" for
simplicity. I also added a note to the README to clarify the differences between these two schemes.
Fixes #62.