Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/974 increase procedure link #975

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

bart-maykin
Copy link
Contributor

@bart-maykin bart-maykin commented Jan 30, 2024

Fixes #974


Changes

  • updated max length of procedure link field
  • updated libraries
  • changed istanbul library for node
  • formatted files according to black

commented out input-color-placeholder sass variables because rijkshuistijl doesn't have !default set for it.

@bart-maykin bart-maykin force-pushed the feature/974-increase-procedure-link branch 2 times, most recently from 5212da3 to e0c38c0 Compare January 30, 2024 11:40
@bart-maykin bart-maykin force-pushed the feature/974-increase-procedure-link branch 2 times, most recently from 3da119c to d55cea4 Compare January 30, 2024 15:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (20d57d4) 93.68% compared to head (2b7fd39) 93.68%.

Files Patch % Lines
src/sdg/accounts/forms.py 0.00% 1 Missing ⚠️
src/sdg/producten/forms.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         379      380    +1     
  Lines        9602     9602           
=======================================
  Hits         8996     8996           
  Misses        606      606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bart-maykin bart-maykin force-pushed the feature/974-increase-procedure-link branch from d55cea4 to 3de4f4b Compare January 30, 2024 15:17
@bart-maykin bart-maykin marked this pull request as ready for review January 30, 2024 15:18
@bart-maykin bart-maykin force-pushed the feature/974-increase-procedure-link branch from 3de4f4b to 2b7fd39 Compare January 30, 2024 15:29
@joeribekker joeribekker merged commit fbc9645 into master Jan 30, 2024
10 checks passed
@joeribekker joeribekker deleted the feature/974-increase-procedure-link branch January 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verhoog de lengte van het veld procedureLink naar 1000 karakters
3 participants