Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing migration for models #35

Closed
wants to merge 1 commit into from
Closed

Add missing migration for models #35

wants to merge 1 commit into from

Conversation

SonnyBA
Copy link

@SonnyBA SonnyBA commented Sep 17, 2024

@SonnyBA SonnyBA self-assigned this Sep 17, 2024
Coperh
Coperh reviewed Sep 17, 2024
View reviewed changes
Copy link

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice this was missing but I don't think anything changed so I wonder why this is now required?

@SonnyBA
Copy link
Author

SonnyBA commented Sep 17, 2024

I noticed the existing authorizations app now, which already had the migrations that were added in this PR. I also see that in open-api-framework the app is missing in the INSTALLED_APPS (link, should be like this). I'm declining this PR because open-api-framework needs to be updated to fix this issue.

@SonnyBA SonnyBA closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coperh Coperh Coperh left review comments

@stevenbal stevenbal Awaiting requested review from stevenbal

@annashamray annashamray Awaiting requested review from annashamray

@bart-maykin bart-maykin Awaiting requested review from bart-maykin

Assignees

@SonnyBA SonnyBA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SonnyBA @Coperh