Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Install README, ChangeLog, GeoIP.conf.default etc into docdir (issue #26... #33

Closed
wants to merge 3 commits into from

Conversation

pprindeville
Copy link
Contributor

Fix for issue #26

@oschwald
Copy link
Member

oschwald commented Mar 6, 2015

Thanks. Although I agree the current GeoIP.conf.default is more documentation than a usable conf file, I wonder if it would be preferable if we pre-populated it with the values for GeoLite downloads, making it usable as is.

@pprindeville
Copy link
Contributor Author

Then that would be installed as /etc/GeoIP.conf instead, right?

@oschwald
Copy link
Member

oschwald commented Mar 6, 2015

Yeah, it would be installed to the sysconf directory.

@pprindeville
Copy link
Contributor Author

Okay, so what's the appropriate fix then?

@oschwald
Copy link
Member

oschwald commented Mar 9, 2015

If you wanted to do it, you could change the default config so that it contains something like this (with the existing comments):

LicenseKey 000000000000
UserId 0
ProductIds 506 517 533 GeoLite2-Country GeoLite2-City

And then revert the change that installs the config into the docs directory.

@pprindeville
Copy link
Contributor Author

I think packaging both a candidate /etc/GeoIP.conf and a template version of $(docdir)/$(PACKAGE_NAME)/GeoIP.conf.default is the best solution.

@oschwald
Copy link
Member

oschwald commented Mar 9, 2015

Sure, that seems fine.

@oschwald
Copy link
Member

Sorry, I didn't realize you updated this. I had one comment about the generated config.

@jippi
Copy link

jippi commented Jul 31, 2016

did this stall?

@oschwald
Copy link
Member

@jippi, thanks for the reminder. I made the requested changes and merged this from the command line.

@oschwald oschwald closed this Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants